Fix RESTEasy Reactive match bug #28442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When matching literals we break out of the wrong loop
|
Did you spot a specific issue that this fixes? Asking because I don't see it mentioned in the description. |
geoand
approved these changes
Oct 7, 2022
|
The test covers the issue. Basically if you have a pattern with a literal in the middle of the pattern and the literal fails to match it breaks out of the wrong loop, and continues to attempt to match. If a subsequent regex then matches the match is considered to be true, even though it should have failed on the literal match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching literals we break out of the wrong loop