Make sure the app model is initialized from the POMs provided by the Maven plugin #28419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/devtools
Maven plugin that could be manipulated by Maven extensions
aloubyansky
force-pushed
the
jgitver-support
branch
from
95b603f
to
a426f6a
Compare
geoand
approved these changes
Oct 6, 2022
|
@aloubyansky is it really safe to backport? |
|
It should be safe. If we want to support POM manipulating Maven extensions in 2.13, we'll need this change backported. But I am not insisting on the backport. We could do it on demand later, I suppose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28375
This change makes sure the
quarkus-maven-plugincan bootstrap an app using POMs manipulated by Maven extensions.There are a couple of cases when we can't re-use the POMs provided by the Maven plugin API. For example, when we launched an app in dev mode and POM file was modified, which triggered a reload. In this case, the POMs provided by the Maven plugin API have to be abandoned and we need to read the new versions of the POMs directly from the disk bypassing the enabled Maven extensions. The other one would be bootstrapping apps for tests, where we don't have access to the original POMs provided by the Maven plugin API.