Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to datasource guide for JDBC and datasource extensions #28400

Merged
merged 2 commits into from Oct 5, 2022

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Oct 5, 2022

Before this patch, there are a few missing links to guides in the dev-mode landing page and in the dev UI (see below).

While I agree this patch assigns links to the same guide to multiple extensions and that's not ideal, I think it's still better than having extensions that, at first sight, would seem undocumented.

Maybe we should do the same for other extensions, such as Vert.x - HTTP?

nodoc

nodoc-devui

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 5, 2022

Failing Jobs - Building 6daaa49

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/opentelemetry/opentelemetry/deployment 
! Skipped: integration-tests/micrometer-prometheus integration-tests/opentelemetry-vertx 

📦 extensions/opentelemetry/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.instrumentation.RestClientOpenTelemetryTest.client line 65 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <SERVER> but was: <CLIENT>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

Quarkus Documentation automation moved this from To do to Reviewer approved Oct 5, 2022
@gsmet gsmet merged commit caee2d8 into quarkusio:main Oct 5, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 5, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.2.Final Oct 10, 2022
@yrodiere yrodiere deleted the datasource-guide-links branch October 28, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants