Retry the admin token acquisition in DevServices for Keycloak #28294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sberyozkin let's not merge it right away. I will orchestrate a few CI runs to ensure it's not failing too often as a first check. |
This comment has been minimized.
This comment has been minimized.
gsmet
force-pushed
the
retry_admin_token_acquisition_keycloak
branch
from
f07aba6
to
10d0dd5
Compare
|
Thanks @gsmet, I'll merge then once the build completes |
|
@sberyozkin let me run it a few more times, please. |
|
@gsmet Sure, sounds good |
This comment has been minimized.
This comment has been minimized.
gsmet
force-pushed
the
retry_admin_token_acquisition_keycloak
branch
from
10d0dd5
to
f121147
Compare
|
Ok I ran it three times. Let’s try to merge and see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gsmet, it is the only try I'd like to make to address both
oidc-client-reactiveand (re-enabled)oidc-token-propagation-reactivetest failures - both fail unexpectedly when an attempt it made to acquire an admin token using theadmin:admindefault admin credentials provided to Keycloak at startup, with the error message that these credentials are invalid.The only thing I can think of is that the admin realm/users data have not been initialized yet in Keycloak. Keycloak 19.0.2 (Quarkus based) has done some significant refactorings around the way the various data are handled, so it might explain why. Other tests which use legacy Keycloak 19.0.2 images are not affected with such an error...
So I've just moved the code dedicated to acquiring the admin token in its own function, and added a retry of up to 10 secs to the code which uses a password grant to get such tokens.
Will disable both of these tests if it does not help