Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "deployment" dependency on org.graalvm.nativeimage.impl package #28084

Merged
merged 1 commit into from Sep 20, 2022

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 20, 2022

Resolves errors (appearing after #27728) like:

[error]: Build step io.quarkus.deployment.steps.NativeImageFeatureStep#generateFeature threw an exception: java.lang.IllegalAccessError: class io.quarkus.deployment.steps.NativeImageFeatureStep (in unnamed module @0x53fa18a5) cannot access class org.graalvm.nativeimage.impl.ConfigurationCondition (in module org.graalvm.sdk) because module org.graalvm.sdk does not export org.graalvm.nativeimage.impl to unnamed module @0x53fa18a5

Note that this is a temporary work-around until the reliance on org.graalvm.nativeimage.impl is completely dropped in favor of using public APIs only as discussed in #27728 (comment).

Fixes graalvm/mandrel#417

Resolves errors like:

```
[error]: Build step io.quarkus.deployment.steps.NativeImageFeatureStep#generateFeature threw an exception: java.lang.IllegalAccessError: class io.quarkus.deployment.steps.NativeImageFeatureStep (in unnamed module @0x53fa18a5) cannot access class org.graalvm.nativeimage.impl.ConfigurationCondition (in module org.graalvm.sdk) because module org.graalvm.sdk does not export org.graalvm.nativeimage.impl to unnamed module @0x53fa18a5
```

Note that this is a temporary work-around until the reliance on
`org.graalvm.nativeimage.impl` is completely dropped in favour of using
public APIs only.
@zakkak
Copy link
Contributor Author

zakkak commented Sep 20, 2022

@jerboaa can you please review this?

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking forward to get rid of those impl classes from GraalVM.

@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 20, 2022
@zakkak
Copy link
Contributor Author

zakkak commented Sep 20, 2022

LGTM. Looking forward to get rid of those impl classes from GraalVM.

It's WIP (see #28093), we still need a couple of changes upstream to make it possible (see oracle/graal#5013)

@jerboaa
Copy link
Contributor

jerboaa commented Sep 20, 2022

It's WIP (see #28093), we still need a couple of changes upstream to make it possible (see oracle/graal#5013)

Excellent, thank you!

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2022

Failing Jobs - Building e9133ed

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-reactive-messaging-amqp/deployment 
! Skipped: integration-tests/reactive-messaging-amqp 

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest.test line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest.testCodeUpdate line 44 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testConsumerUpdate line 77 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest 
Expecting size of:

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testProducerUpdate - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2076)

io.quarkus.smallrye.reactivemessaging.amqp.SecuredAmqpTest.test line 28 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.SecuredAmqpTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gastaldi gastaldi merged commit 43da21b into quarkusio:main Sep 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 20, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 20, 2022
@zakkak zakkak deleted the gradle-it-fix branch September 20, 2022 19:42
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVM 22.3.0-dev Quarkus native readiness tracker
4 participants