Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codestart properties with yaml null key #28081

Merged
merged 1 commit into from Sep 20, 2022

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Sep 20, 2022

In codestarts, config is always written in yaml.

When using ~ as documented here https://quarkus.io/guides/config-yaml#configuration-key-conflicts, then generated application.properties is wrong .~=:
e.g.:

quarkus:
  quinoa:
    package-manager-install:
      ~: true
      node-version: 16.17.0
    dev-server:
      port: 3000

gives:

quarkus.quinoa.package-manager-install.~=true
quarkus.quinoa.dev-server.port=3000
quarkus.quinoa.package-manager-install.node-version=16.17.0

This fix is making sure we generate this instead:

quarkus.quinoa.package-manager-install=true
quarkus.quinoa.dev-server.port=3000
quarkus.quinoa.package-manager-install.node-version=16.17.0

@quarkus-bot quarkus-bot bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 20, 2022
@ia3andy ia3andy merged commit 9ed77a6 into quarkusio:main Sep 20, 2022
@ia3andy ia3andy deleted the fix-codestart-properties branch September 20, 2022 12:21
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 20, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants