Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Netty 4.1.82 and Brotli4J 1.8.0 #28077

Merged
merged 1 commit into from Sep 21, 2022
Merged

Update to Netty 4.1.82 and Brotli4J 1.8.0 #28077

merged 1 commit into from Sep 21, 2022

Conversation

cescoffier
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Sep 20, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier
Update to Netty 4.1.82 and Brotli4J 1.8.0
b7954d1 
- Add a substitution to avoid using the BouncyCastle (BC) PEM reader when BC is unavailable.
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2022

Failing Jobs - Building b7954d1

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc-code-flow

📦 integration-tests/oidc-code-flow

✖ io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh line 507 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/tenant-autorefresh?state=53108842-17e7-4401-8fc7-5f3c65039482&session_state=43f7792d-8cf6-4b49-9f56-3c9aaaaa805b&code=d93d076b-0d27-47f7-b1b4-8255a59a7a33.43f7792d-8cf6-4b49-9f56-3c9aaaaa805b.06f6f31a-9bd8-48fe-8555-b9c01a294306
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)

@cescoffier cescoffier merged commit 84f953c into quarkusio:main Sep 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 21, 2022
geoand added a commit to geoand/quarkus that referenced this pull request Sep 21, 2022
@geoand
Remove now redundant code
99d5934 
MessageFormatter and FormattingTuple were originally
copied from Netty because they didn't have the proper
access modifiers for us to use them.
With Netty 4.1.81 now being used in Quarkus, we can now
use the actual classes so let's get rid of the redundancy.

Follows up on: quarkusio#27653, quarkusio#28077
geoand added a commit to geoand/quarkus that referenced this pull request Sep 21, 2022
@geoand
Remove now redundant code
6e64d22 
MessageFormatter and FormattingTuple were originally
copied from Netty because they didn't have the proper
access modifiers for us to use them.
With Netty 4.1.81 now being used in Quarkus, we can now
use the actual classes so let's get rid of the redundancy.

Follows up on: quarkusio#27653, quarkusio#28077
@geoand geoand mentioned this pull request Sep 21, 2022
Merged
@cescoffier cescoffier deleted the netty-4.1.82 branch September 25, 2022 07:44
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.2.Final Oct 10, 2022
igorregis pushed a commit to igorregis/quarkus that referenced this pull request Oct 16, 2022
@geoand @igorregis
Remove now redundant code
0e1c916 
MessageFormatter and FormattingTuple were originally
copied from Netty because they didn't have the proper
access modifiers for us to use them.
With Netty 4.1.81 now being used in Quarkus, we can now
use the actual classes so let's get rid of the redundancy.

Follows up on: quarkusio#27653, quarkusio#28077
igorregis pushed a commit to igorregis/quarkus that referenced this pull request Oct 16, 2022
@geoand @igorregis
Remove now redundant code
1b4e587 
MessageFormatter and FormattingTuple were originally
copied from Netty because they didn't have the proper
access modifiers for us to use them.
With Netty 4.1.81 now being used in Quarkus, we can now
use the actual classes so let's get rid of the redundancy.

Follows up on: quarkusio#27653, quarkusio#28077
igorregis pushed a commit to igorregis/quarkus that referenced this pull request Oct 16, 2022
@geoand @igorregis
Remove now redundant code
9103c74 
MessageFormatter and FormattingTuple were originally
copied from Netty because they didn't have the proper
access modifiers for us to use them.
With Netty 4.1.81 now being used in Quarkus, we can now
use the actual classes so let's get rid of the redundancy.

Follows up on: quarkusio#27653, quarkusio#28077
igorregis pushed a commit to igorregis/quarkus that referenced this pull request Oct 17, 2022
@geoand @igorregis
Remove now redundant code
cbac83b 
MessageFormatter and FormattingTuple were originally
copied from Netty because they didn't have the proper
access modifiers for us to use them.
With Netty 4.1.81 now being used in Quarkus, we can now
use the actual classes so let's get rid of the redundancy.

Follows up on: quarkusio#27653, quarkusio#28077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Milestone
2.13.2.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cescoffier @geoand @gsmet