Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore RESTEasy Classic providers found on classpath #28062

Merged
merged 1 commit into from Sep 19, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 19, 2022

These can end up on the classpath by using the Keycloak client for example and can mess up the handling of request (for example for multipart)

Follows up on: #27981

These can end up on the classpath by using the Keycloak client for example
and can mess up the handling of request (for example for multipart)
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It solves the issue I reported on Zulip to @geoand.

Some details about the failure we have seen:
The fail was related to the fact that we have org.jboss.resteasy:resteasy-multipart-provider on the classpath

Example of failure: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/3075140578/jobs/4968408018

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.748 s - in io.quarkus.ts.http.advanced.reactive.RemoteDevModeHttpAdvancedReactiveIT
[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.testMediaTypePassedToMessageBodyWriter:311->BaseHttpAdvancedReactiveIT.assertAcceptedMediaTypeEqualsResponseBody:340 1 expectation failed.
Response body doesn't match expectation.
Expected: is "application/json"
  Actual: 

@geoand
Copy link
Contributor Author

geoand commented Sep 19, 2022

Thanks for checking!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 19, 2022
@geoand geoand merged commit 5faa68d into quarkusio:main Sep 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 19, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 19, 2022
@geoand geoand deleted the rr-providers-exclude branch September 19, 2022 16:30
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants