Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more OIDC debug messages #28059

Merged
merged 1 commit into from Sep 19, 2022
Merged

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin
Copy link
Member Author

Hope to get this one first and then rerun #28023, as the flaky test failed in #28023

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member Author

@gastaldi Thanks for dealing with my sloppy typing in this PR :-)

@gsmet, agree with you re the disruptive tests for sure; my thinking was, if it fails once every few days then I can keep it open. I've just thought about dealing it in private forks - it can definitely be done, but for tests experiencing the race conditions the chances are lower - example, in my fork I can do now and then with some update - but here the frequency is much higher, for example, we can have 20 PRs for 3 days, and now with the improved logging the chances of catching the problem will increase. That test tests an important but hard to test feature, a session extension via the token refresh, this is why I'd like to get it fixed as opposed to just disabling it... Either way, agree on the overall approach, we'll disable it next week if needed

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 19, 2022
@sberyozkin sberyozkin merged commit e19f65e into quarkusio:main Sep 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 19, 2022
@sberyozkin sberyozkin deleted the oidc_debug_messages branch September 19, 2022 20:05
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 19, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants