Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDOCS-31: Fix image sizing - draft 2 #28020

Merged
merged 1 commit into from Sep 16, 2022

Conversation

sheilamjones
Copy link
Contributor

JIRA: QDOCS-31

Alignment and sizing of newly-added image is incorrect in https://quarkus.io/version/main/guides/security-openid-connect-web-authentication. Fix one (addition of "role" attribute) did not fix. After comparison with fix implemented in https://github.com/quarkusio/quarkus/pull/27432/files (addition of "width=60%" and "align=center" attributes), updated file to implement same here.

@sheilamjones
Copy link
Contributor Author

Hi Sergey,
Thanks so much for your review and insights into this issue. I updated per the fix in the Bearer Token guide and added the width and align attributes. Initially, I had added the "role" attribute after comparing with other guides and also the implementation of "role" is such that it scales the diagram according to the surrounding area. I'm not sure why it didn't work here.
Hope this will do the trick here.
Kind regards,
Sheila

@sheilamjones
Copy link
Contributor Author

And apologies for the slow processing of this fix. I was out on Monday and was sick on Wednesday. Thanks again for highlighting the issue and your help with the fix.
Kind regards,
Sheila

Quarkus Documentation automation moved this from To do to Reviewer approved Sep 16, 2022
@sberyozkin sberyozkin merged commit 9f7fb8d into quarkusio:main Sep 16, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Sep 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 16, 2022
@sberyozkin
Copy link
Member

Hi Sheila @sheilamjones No problems at all :-), thanks very much for your effort, very appreciated 👍

@sheilamjones
Copy link
Contributor Author

@sberyozkin Thanks again for your patience and prompt review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants