DevMojo add only properties from the quarkus namespace

[radcortez]

• Fixes quarkus-config: Maven-Property conflicts with 'prefix' (Regression since Quarkus 2.12) #27884

There is a difference in the recorded properties between the build and dev mode. In dev mode, all properties were being recorded, which cause the issue described in #27884.

[aloubyansky]

@radcortez could you clarify the issue a bit more? I suppose if I pass -Dxyz.version=bla I won't get a warn/error. I am wondering why build system properties would be different.

[radcortez]

When we run in Dev mode, all properties from the Maven model end up in the Build System Config Source. Properties are collected here:

quarkus/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java

Line 986 in fbc44b8

builder.buildSystemProperties((Map) project.getProperties());

And then end up here:

quarkus/core/deployment/src/main/java/io/quarkus/deployment/ExtensionLoader.java

Line 142 in efe6397

public static Consumer<BuildChainBuilder> loadStepsFrom(ClassLoader classLoader, Properties buildSystemProps,

Because we don't recognize these properties, they end up being recorded in the Runtime Defaults source. This issue was always there, but it was only uncovered with the change we did in #26802. Before this PR, the Runtime Defaults source was ignored entirely in Dev Mode.

In regular JVM mode and build, we never got this issue, because we filter the properties coming from the Maven model, to only have the quarkus namespace, here:

https://github.com/radcortez/quarkus/blob/08241672f6e3bae14dc54e8957ae81a943a7a39f/devtools/maven/src/main/java/io/quarkus/maven/QuarkusBootstrapProvider.java#L161-L165

The idea of this PR was also to add the filtering to Dev Mode, so it behave the same way as if we compiled and run. If you have any other ideas, I'm happy to change the approach :)

[aloubyansky]

Makes sense, thanks!

[gsmet]

I rebased it to get another CI run as we had quite a lot of failures.

[radcortez]

Thanks!