Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that @ClientHeaderParam works when the rest client contains a method with a primitive return type #27961

Merged
merged 1 commit into from Sep 16, 2022
Merged

Ensure that @ClientHeaderParam works when the rest client contains a method with a primitive return type #27961

merged 1 commit into from Sep 16, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 15, 2022 •
edited

Resolves: #27959

@geoand geoand mentioned this pull request Sep 15, 2022
Closed
Sgitario
Sgitario approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

...src/main/java/io/quarkus/rest/client/reactive/deployment/MicroProfileRestClientEnricher.java
@@ -445,7 +433,7 @@ private String mockInterface(ClassInfo declaringClass, BuildProducer<GeneratedCl
for (MethodInfo method : methods) {
if (Modifier.isAbstract(method.flags())) {
MethodCreator methodCreator = classCreator.getMethodCreator(MethodDescriptor.of(method));
methodCreator.returnValue(methodCreator.loadNull());
methodCreator.throwException(IllegalStateException.class, "This should never be called");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, the issue was that we were returning null for primitive types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisely

@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor Author

geoand commented Sep 15, 2022

The test failures definitely look related

@sberyozkin
Copy link
Member

oidc-token-propagation-reactive is likely not, I've seen it failing here #27737 (comment), I'll add to the list in the OIDC flaky tests issue

@geoand
Copy link
Contributor Author

geoand commented Sep 15, 2022

Yeah, I meant the TCK tests

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 15, 2022
@gastaldi gastaldi merged commit 06944a5 into quarkusio:main Sep 16, 2022
@gastaldi gastaldi deleted the #27959 branch September 16, 2022 00:11
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 16, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 16, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@Sgitario Sgitario Sgitario approved these changes

Assignees
No one assigned
Labels
area/resteasy-reactive kind/bugfix
Projects
None yet
Milestone
2.13.0.Final
Development

Successfully merging this pull request may close these issues.

OIDC scenarion with authorization using @ClientHeaderParam doesn't work after move to reactive
5 participants
@geoand @sberyozkin @gastaldi @Sgitario @gsmet