Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce native-image -H: options #27783

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 7, 2022

-H: options are considered non-public and should thus be avoided as they can change without notice.

Part of #27784
Relates to #25943

@zakkak zakkak added this to the 2.13 - main milestone Sep 7, 2022
@zakkak zakkak requested a review from geoand September 7, 2022 13:00
@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 7, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zakkak
Copy link
Contributor Author

zakkak commented Sep 7, 2022

I rebased to get CI to run (it was stuck for some reason).

@quarkus-bot

This comment has been minimized.

`inlineBeforeAnalysis` is always enabled starting from GraalVM
21.3 (which is the minimum supported version)
`-H:` options are considered non-public and should thus be avoided as
they can change without notice.
@geoand
Copy link
Contributor

geoand commented Sep 8, 2022

@zakkak is this meant to resolve #27784?

If so, please update the PR description

@zakkak
Copy link
Contributor Author

zakkak commented Sep 8, 2022

@zakkak is this meant to resolve #27784?

Not entirely.

If so, please update the PR description

Done.

@geoand
Copy link
Contributor

geoand commented Sep 8, 2022

Great, thanks

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2022

Failing Jobs - Building 3551b45

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-reactive-messaging-amqp/deployment 
! Skipped: integration-tests/reactive-messaging-amqp 

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest.test line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest.testCodeUpdate line 44 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testConsumerUpdate - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2076)

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testProducerUpdate line 48 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest 
Expecting size of:

io.quarkus.smallrye.reactivemessaging.amqp.SecuredAmqpTest.test - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2076)

@zakkak
Copy link
Contributor Author

zakkak commented Sep 8, 2022

CI issues seem unrelated to the PR. The PR affects only native images.

@zakkak zakkak merged commit 68bea9c into quarkusio:main Sep 8, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 8, 2022
@zakkak zakkak deleted the reduce-H-options branch September 8, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants