Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyway callbacks can now access the Flyway instance #27770

Merged
merged 1 commit into from Sep 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -35,6 +35,7 @@
import io.quarkus.agroal.spi.JdbcInitialSQLGeneratorBuildItem;
import io.quarkus.arc.deployment.AdditionalBeanBuildItem;
import io.quarkus.arc.deployment.SyntheticBeanBuildItem;
import io.quarkus.arc.deployment.SyntheticBeansRuntimeInitBuildItem;
import io.quarkus.arc.processor.DotNames;
import io.quarkus.builder.item.SimpleBuildItem;
import io.quarkus.datasource.common.runtime.DataSourceUtil;
Expand All @@ -43,6 +44,7 @@
import io.quarkus.deployment.annotations.BuildStep;
import io.quarkus.deployment.annotations.Consume;
import io.quarkus.deployment.annotations.ExecutionTime;
import io.quarkus.deployment.annotations.Produce;
import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
import io.quarkus.deployment.builditem.FeatureBuildItem;
Expand Down Expand Up @@ -151,16 +153,15 @@ private void addJavaMigrations(Collection<ClassInfo> candidates, RecorderContext
}

@BuildStep
@Produce(SyntheticBeansRuntimeInitBuildItem.class)
@Consume(LoggingSetupBuildItem.class)
@Record(ExecutionTime.RUNTIME_INIT)
ServiceStartBuildItem createBeansAndStartActions(FlywayRecorder recorder,
void createBeans(FlywayRecorder recorder,
List<JdbcDataSourceBuildItem> jdbcDataSourceBuildItems,
List<JdbcInitialSQLGeneratorBuildItem> sqlGeneratorBuildItems,
BuildProducer<AdditionalBeanBuildItem> additionalBeans,
BuildProducer<SyntheticBeanBuildItem> syntheticBeanBuildItemBuildProducer,
BuildProducer<JdbcDataSourceSchemaReadyBuildItem> schemaReadyBuildItem,
MigrationStateBuildItem migrationsBuildItem) {

// make a FlywayContainerProducer bean
additionalBeans.produce(AdditionalBeanBuildItem.builder().addBeanClasses(FlywayContainerProducer.class).setUnremovable()
.setDefaultScope(DotNames.SINGLETON).build());
Expand Down Expand Up @@ -197,7 +198,14 @@ ServiceStartBuildItem createBeansAndStartActions(FlywayRecorder recorder,

syntheticBeanBuildItemBuildProducer.produce(configurator.done());
}
}

@BuildStep
@Consume(SyntheticBeansRuntimeInitBuildItem.class)
@Record(ExecutionTime.RUNTIME_INIT)
public ServiceStartBuildItem startActions(FlywayRecorder recorder,
BuildProducer<JdbcDataSourceSchemaReadyBuildItem> schemaReadyBuildItem,
MigrationStateBuildItem migrationsBuildItem) {
// will actually run the actions at runtime
recorder.doStartActions();

Expand Down
@@ -0,0 +1,48 @@
package io.quarkus.flyway.test;

import java.util.Arrays;
import java.util.List;

import javax.enterprise.inject.spi.CDI;

import org.flywaydb.core.Flyway;
import org.flywaydb.core.api.callback.Callback;
import org.flywaydb.core.api.callback.Context;
import org.flywaydb.core.api.callback.Event;

public class FlywayExtensionCDICallback implements Callback {

public static List<Event> DEFAULT_EVENTS = Arrays.asList(
Event.BEFORE_BASELINE,
Event.AFTER_BASELINE,
Event.BEFORE_MIGRATE,
Event.BEFORE_EACH_MIGRATE,
Event.AFTER_EACH_MIGRATE,
Event.AFTER_VERSIONED,
Event.AFTER_MIGRATE,
Event.AFTER_MIGRATE_OPERATION_FINISH);

@Override
public boolean supports(Event event, Context context) {
return DEFAULT_EVENTS.contains(event);
}

@Override
public boolean canHandleInTransaction(Event event, Context context) {
return true;
}

@Override
public void handle(Event event, Context context) {
try {
CDI.current().select(Flyway.class).get();
} catch (Exception exception) {
throw new IllegalStateException(exception);
}
}

@Override
public String getCallbackName() {
return "Quarked Flyway Callback with CDI";
}
}
Expand Up @@ -40,7 +40,7 @@ public class FlywayExtensionCallbackTest {
.setAfterAllCustomizer(customizer::stopH2)
.withApplicationRoot((jar) -> jar
.addClasses(FlywayH2TestCustomizer.class,
FlywayExtensionCallback.class, FlywayExtensionCallback2.class)
FlywayExtensionCallback.class, FlywayExtensionCallback2.class, FlywayExtensionCDICallback.class)
.addAsResource("db/migration/V1.0.3__Quarkus_Callback.sql")
.addAsResource("callback-config.properties", "application.properties"));

Expand Down
Expand Up @@ -7,4 +7,4 @@ quarkus.datasource.jdbc.url=jdbc:h2:tcp://localhost:11303/mem:quarkus-flyway-cal
quarkus.flyway.migrate-at-start=true
quarkus.flyway.baseline-on-migrate=true
quarkus.flyway.baseline-version=0.0.1
quarkus.flyway.callbacks=io.quarkus.flyway.test.FlywayExtensionCallback,io.quarkus.flyway.test.FlywayExtensionCallback2
quarkus.flyway.callbacks=io.quarkus.flyway.test.FlywayExtensionCallback,io.quarkus.flyway.test.FlywayExtensionCallback2,io.quarkus.flyway.test.FlywayExtensionCDICallback