Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to check the runtime log level for RequestContext tracing needs #27736

Merged
merged 1 commit into from Sep 6, 2022
Merged

Ensure to check the runtime log level for RequestContext tracing needs #27736

merged 1 commit into from Sep 6, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Sep 5, 2022 •
edited by geoand

Fixes #27735
Fixes #27743

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 5, 2022
@Sanne Sanne requested a review from mkouba September 5, 2022 17:56
@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 5, 2022
franz1981
franz1981 reviewed Sep 5, 2022
View reviewed changes
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/RequestContext.java
@@ -126,7 +122,7 @@ public void destroy(Contextual<?> contextual) {

@Override
public void activate(ContextState initialState) {
if (traceEnabled) {
if (LOG.isTraceEnabled()) {
String stack = Arrays.stream(Thread.currentThread().getStackTrace())
Copy link
Contributor

@franz1981 franz1981 Sep 5, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but useful: always move away "unlikely" paths ie cold ones out of the "main" method logic: it would increase chances to inline it (see http://normanmaurer.me/blog_in_progress/2013/11/07/Inline-all-the-Things/ that's still very actual and these things hasn't changed across JDK versions, really).
Most inlining decisions on OpenJDK happens based on the bytecode size (although not always; sometime the native method size is important too), meaning that using any bytecode plugin viewer (I use https://plugins.jetbrains.com/plugin/9248-jclasslib-bytecode-viewer) can help checking how much the bytecode size change while grouping differently code into methods:
eg

if (LOG.isTraceEnabled()) {
    traceActivate(...);
}

this is going to reduce a bit the bytecode size of the original method, increasing its chance to be inlined in the common use case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true, but in this case I preferred the simplest patch to expedite integration & minimize friction for backports.

Definitely something to consider if someone wants to get back to this and improve further.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 5, 2022

Failing Jobs - Building 854e87a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: extensions/smallrye-reactive-messaging-amqp/deployment 
! Skipped: integration-tests/reactive-messaging-amqp

📦 extensions/smallrye-reactive-messaging-amqp/deployment

✖ io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest.test line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

franz1981
franz1981 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@franz1981 franz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified in our perf lab that's going to fix the performance regression seen on current master.

@geoand geoand merged commit 90ae8fb into quarkusio:main Sep 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 6, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 6, 2022
@geoand
Copy link
Contributor

geoand commented Sep 6, 2022

Thanks for the fix @Sanne!

This also fixed #27743, which initially had me really worried 😌 .

@geoand
Copy link
Contributor

geoand commented Sep 6, 2022 •
edited

It goes without saying that this should be most important thing we backport to 2.12.

@geoand geoand mentioned this pull request Sep 6, 2022
Closed
@Sanne Sanne deleted the AllocationsRegression branch September 6, 2022 10:24
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franz1981 franz1981 franz1981 approved these changes

@gastaldi gastaldi gastaldi approved these changes

@manovotn manovotn manovotn approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Milestone
2.12.1.Final
6 participants
@Sanne @geoand @gastaldi @manovotn @franz1981 @gsmet