Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor correction in a doc #27704

Merged
merged 1 commit into from Sep 4, 2022
Merged

Minor correction in a doc #27704

merged 1 commit into from Sep 4, 2022

Conversation

ynojima
Copy link
Member

@ynojima ynojima commented Sep 3, 2022

Note section in security-openid-connect-multitenancy.adoc is broken

Asciidoc NOTE section syntax: https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#admonitions

@@ -149,7 +149,7 @@ public class CustomTenantResolver implements TenantResolver {
From the implementation above, tenants are resolved from the request path so that in case no tenant could be inferred, `null` is returned to indicate that the default tenant configuration should be used.

[NOTE]
===
====
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing one is also three equal signs. And I can see that others in the same doc have the same issue. Could you fix all of them? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I fixed it in the next commit

Quarkus Documentation automation moved this from To do to Review pending Sep 3, 2022
Note section in security-openid-connect-multitenancy.adoc is broken
Quarkus Documentation automation moved this from Review pending to Reviewer approved Sep 4, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I squashed the commits, let's wait for CI.

@gsmet gsmet merged commit f22ead6 into quarkusio:main Sep 4, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Sep 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 4, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants