Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop depending on com.oracle.svm.core.jdk.Resources#registerResource #27690

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 2, 2022

Use the new public API to be shipped with GraalVM 22.3 instead when available.

Relates to #25943

@quarkus-bot quarkus-bot bot added the area/core label Sep 2, 2022
Use the new public API to be shipped with GraalVM 22.3 instead when
available.
@zakkak zakkak force-pushed the drop-internal-resources-dependency branch from b1b2ab0 to 76ca22d Compare September 2, 2022 12:37
@zakkak
Copy link
Contributor Author

zakkak commented Sep 2, 2022

@geoand after your review I noticed a more generic API which takes care of the ImageSingletons.lookup so used that instead, please consider re-reviewing. Sorry for the inconvenience.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 2, 2022

Failing Jobs - Building 76ca22d

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 line 54 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 4 State{lastRun=3, running=true, inProgress=true, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3(KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.java:54)

@zakkak
Copy link
Contributor Author

zakkak commented Sep 5, 2022

The CI failure seems unrelated to the PR.

@geoand geoand merged commit b1e79ce into quarkusio:main Sep 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 5, 2022
@zakkak zakkak deleted the drop-internal-resources-dependency branch September 5, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants