Funqy - fix constructor injection for normal scoped beans #27674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
approved these changes
Sep 1, 2022
geoand
approved these changes
Sep 2, 2022
mkouba
reviewed
Sep 2, 2022
| @@ -172,6 +172,12 @@ private static void generateDefaultConstructors(BuildProducer<BytecodeTransforme | |||
| Set<ClassInfo> withoutDefaultCtor) { | |||
|
|
|||
| for (ClassInfo classInfo : withoutDefaultCtor) { | |||
| // don't generate constructor for normal scoped beans as the Quarkus Arc does that for us | |||
There was a problem hiding this comment.
So in theory, custom scopes can be normal as well. On the other hand, this solution probably covers 99% of use cases. Also the CustomScopeAnnotationsBuildItem can only be used to test the scope annotations and not whether they represent a normal scope.
There was a problem hiding this comment.
Didn't know that, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #27671
Default no-args constructor is not generated for normal scoped beans anymore.