Always instantiate Hibernate ORM collections in the default fetch group #27666
+484
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-orm
Sanne
approved these changes
Sep 1, 2022
yrodiere
force-pushed
the
enableCollectionInDefaultFetchGroup
branch
from
3dc26d7 to
33cc9d0
Compare
yrodiere
added
the
triage/waiting-for-ci
|
Cool. Is this going to make it into Quarkus 2.12.1 ? |
I'm not sure that would be wise... It's a rather significant change, and could have a (small) performance impact. @Sanne, any opinion on that? |
|
I'd prefer it to be limited to the next minor but I have no strong opinion. |
|
FWIW I submitted a PR (hibernate/hibernate-orm#5252) to make this the default in Hibernate ORM 6.2. I hade to change a few tests though; and that won't become the default in 5.x (which Quarkus currently uses, and will use until we migrate to Jakarta EE). This is a rather complex situation, so I'll discuss with @gsmet when/where he thinks it would be best to merge this. |
yrodiere
added
triage/needs-decision
…n tests It was acceptable before we fixed HHH-14620, but now that initializing a property doesn't imply initializing the collection, it's just plain wrong.
yrodiere
force-pushed
the
enableCollectionInDefaultFetchGroup
branch
from
33cc9d0 to
2f77645
Compare
gsmet
approved these changes
Sep 7, 2022
gsmet
added
triage/backport?
and removed
triage/needs-decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... be it for Hibernate Reactive (as before) or for Hibernate ORM.
Fixes #27657
Fixes #4644 (according to #27657 (reply in thread))
Fixes problems such as #27657, where calling a getter to retrieve a collection on an initialized entity would throw a
LazyInitializationException, whereas one would expect the exception to be thrown later, when accessing the collection itself (.size(),.iterator(), ...).This sets defaults as suggested by @gavinking and @Sanne when the option was introduced some time ago: hibernate/hibernate-orm#3558 (comment), hibernate/hibernate-orm#3558 (comment)