Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use devRootAppend for all links in grpc devmode #27655

Merged
merged 1 commit into from Sep 1, 2022
Merged

Use devRootAppend for all links in grpc devmode #27655

merged 1 commit into from Sep 1, 2022

Conversation

0SkillAllLuck
Copy link
Contributor

@0SkillAllLuck 0SkillAllLuck commented Sep 1, 2022

Use devRootAppend for all links and the web socket connection on gRPC devmode pages.

Fixes: #27654

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Sep 1, 2022
@quarkus-bot

This comment has been minimized.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 1, 2022
@geoand
Copy link
Contributor

geoand commented Sep 1, 2022

Thanks!

@geoand geoand merged commit 98ff612 into quarkusio:main Sep 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 1, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 1, 2022
@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? and removed kind/bugfix labels Sep 1, 2022
@0SkillAllLuck 0SkillAllLuck deleted the fix-grpc-devmode-links branch September 1, 2022 11:11
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC DevMode not working with custom non-application-root-path
3 participants