BeanManager.getBeans() - assume the default qualifier if none specified

[mkouba]

• this behavior is defined by the spec

[mkouba]

See also https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/.40InjectMock.20incorrect.20resolution

[mkouba]

The CI failure seems to be related...

[quarkus-bot]

Failing Jobs - Building 60f62f7

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 17
✖	JVM Tests - JDK 18	Build	Failures	Logs	Raw logs
✔️	Maven Tests - JDK 11
⌛	Maven Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with com.example.grpc.hibernate.BlockingRawTest was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

[gsmet]

@mkouba could you prepare a note about the potential compatibility issue? I see you had to add some qualifiers to some tests. Just add it as a comment here and I will include it in the 2.12.1 announcement blog post. Thanks!

[mkouba]

@mkouba could you prepare a note about the potential compatibility issue? I see you had to add some qualifiers to some tests. Just add it as a comment here and I will include it in the 2.12.1 announcement blog post. Thanks!

So this change should only affect code that directly/indirectly makes use of the BeanManager.getBeans(Type, Annotation...) method and does not pass any required qualifiers, i.e. regular injection, programmatic lookup and code like beanManager.getBeans(Foo.class, MyQualifier.Literal.INSTANCE) is not affected. The difference is that previously if no qualifier was specified then the behavior was the same as if the @Any qualifier was used, i.e. all beans matching the required type were resolved. In general, a user can get an unsatisfied dependency exception at runtime (e.g. during tests when @InjectMock is used). The solution is to use an appropriate qualifier or @Any.

[manovotn]

Note that this change is also aligning the behavior with CDI specification. Therefore, if users expected/relied on different behavior, it was not warranted by spec.
See https://github.com/jakartaee/cdi/blob/master/api/src/main/java/jakarta/enterprise/inject/spi/BeanContainer.java#L75