Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSE cancellation in the Reactive REST Client #27559

Merged
merged 1 commit into from Aug 29, 2022
Merged

Fix SSE cancellation in the Reactive REST Client #27559

merged 1 commit into from Aug 29, 2022

Conversation

cescoffier
Copy link
Member

Fix #27489.

@cescoffier cescoffier requested a review from geoand August 29, 2022 06:35
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 29, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2022

Failing Jobs - Building d876224

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/micrometer-prometheus

📦 integration-tests/micrometer-prometheus

✖ io.quarkus.it.micrometer.prometheus.ClientRequestTest.testClientRequests line 36 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@geoand geoand merged commit f327d4c into quarkusio:main Aug 29, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 29, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 29, 2022
@cescoffier cescoffier deleted the sse-client-cancellation branch August 29, 2022 09:49
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/rest-client kind/bugfix
Projects
None yet
Milestone
2.12.1.Final
Development

Successfully merging this pull request may close these issues.

Mutiny Dropped Exception on SSE Cancel
3 participants
@cescoffier @geoand @gsmet