Make sending OIDC client id with introspection credentials optional #27449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Aug 23, 2022
This comment has been minimized.
This comment has been minimized.
|
Hmm, I'm puzzled how such a PR can cause so many failures, going to check, sorry |
sberyozkin
force-pushed
the
oidc_introspection_auth_optional_client_id
branch
from
a83345c
to
d6ea482
Compare
|
The test created |
gsmet
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27442
This PR adds a boolean configuration property making it possible to skip sending the OIDC client id when using the custom/basic introspection authentication. I haven't added a test as testing this case is quite involved (see #26917) so I'm not sure these PR changes need another test like the one added in #26917, but I can work on it if preferred