Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system properties source to CodeGenerator config sources #27436

Merged
merged 1 commit into from Aug 23, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 23, 2022

Resolves: #27431

@michalszynkiewicz
Copy link
Member

@geoand It looks good, did you have a way to check if it works? ;)

@geoand
Copy link
Contributor Author

geoand commented Aug 23, 2022

I do not, I am hoping @jamesnetherton does :)

@jamesnetherton
Copy link
Contributor

I did a quick local test and I could resolve system properties via the provided Config object in my CodeGenProvider.

@geoand
Copy link
Contributor Author

geoand commented Aug 23, 2022

Great, thanks for checking!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Aug 23, 2022
@gsmet gsmet merged commit 7e8847c into quarkusio:main Aug 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 23, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 23, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.0.Final Aug 23, 2022
@geoand geoand deleted the #27431 branch August 24, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default config sources to codegen config
4 participants