New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load CodeGenProvider services once instead of once per module #27288
Load CodeGenProvider services once instead of once per module #27288
Conversation
This comment has been minimized.
This comment has been minimized.
6b7f1ff
to
3ac12f4
Compare
Failing Jobs - Building 3ac12f4
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/rest-client
📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/opentelemetry-vertx integration-tests/rest-client
📦 integration-tests/opentelemetry-vertx✖
📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/rest-client
📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ JVM Tests - JDK 18 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment integration-tests/rest-client
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ Native Tests - HTTP #- Failing: integration-tests/rest-client
📦 integration-tests/rest-client✖
✖
✖
✖
|
The failures aren't related to the change. I'll rebase to make sure it's all good. |
#27320 should fix the test failures. |
I noticed that we load
CodeGenProvider
services for each module in a multimodule project and we also never close the deployment classloader created to look for theCodeGenProvider
implementations. This PR fixes both issues.