Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop getRequiredFeatures method from io.quarkus.runner.Feature #27263

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Aug 12, 2022

In #25976 we switched from using the @AutomaticFeature annotation to explicitly passing the required features using the --features parameter.

Given that @AutomaticFeatures (including the SerializationFeature) are always registered before non-automatic ones there is no longer the need to have an explicit dependency on SerializationFeture.

This is related to #25943

In quarkusio#25976 we switched from
using the @AutomaticFeature annotation to explicitly passing the
required features using the --features parameter.

Given that `@AutomaticFeature`s (including the `SerializationFeature`) are
always registered before non-automatic ones there is no longer the need
to have an explicit dependency on `SerializationFeture`.
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 12, 2022

Failing Jobs - Building fee232a

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.SimpleContextPropagationTest.testArcMEContextPropagationDisabled line 83 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 18 #

- Failing: extensions/reactive-pg-client/deployment 
! Skipped: extensions/hibernate-reactive/deployment extensions/panache/hibernate-reactive-panache-common/deployment extensions/panache/hibernate-reactive-panache/deployment and 11 more

📦 extensions/reactive-pg-client/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.2:start (docker-start) on project quarkus-reactive-pg-client-deployment: I/O Error

@gsmet gsmet merged commit c3d6891 into quarkusio:main Aug 17, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 17, 2022
@zakkak zakkak deleted the drop-serializationfeature-feature-dependency branch August 17, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants