New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to SmallRye GraphQL 1.7.0 (graphql-java 19.0) #27214
Conversation
eadd014
to
f4586f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know that already but just so that it doesn't get merged too soon: we will need a Jakarta version and an update to the rewrite.yml file.
Thanks.
That is why this is still a draft. Busy with the 2.0.0.RC release |
f4586f0
to
2b87b5c
Compare
This comment has been minimized.
This comment has been minimized.
Failures look related. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
2b87b5c
to
694cacc
Compare
@gsmet Yes native failed due to new i18n resource from graphql-java. Fixed now. Should be ok, lets see what CI does now. |
Failing Jobs - Building 694cacc
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
Thanks @gsmet ! |
This PR upgrades to SmallRye GraphQL 1.7.0 that contains a new version of graphql-java (v19.0). The validation messages now supports i18n and the default message changed slightly (hence the overrides in the MicroProfile GraphQL TCK)
This PR also adds some new configuration options:
Signed-off-by: Phillip Kruger phillip.kruger@gmail.com