Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SmallRye GraphQL 1.7.0 (graphql-java 19.0) #27214

Merged
merged 1 commit into from Aug 11, 2022

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Aug 10, 2022

This PR upgrades to SmallRye GraphQL 1.7.0 that contains a new version of graphql-java (v19.0). The validation messages now supports i18n and the default message changed slightly (hence the overrides in the MicroProfile GraphQL TCK)

This PR also adds some new configuration options:

  • quarkus.smallrye-graphql.instrumentation-query-complexity
  • quarkus.smallrye-graphql.instrumentation-query-depth
  • quarkus.smallrye-graphql.parser-capture-ignored-chars
  • quarkus.smallrye-graphql.parser-capture-line-comments
  • quarkus.smallrye-graphql.parser-capture-source-location
  • quarkus.smallrye-graphql.parser-max-tokens
  • quarkus.smallrye-graphql.parser-max-whitespace-tokens

Signed-off-by: Phillip Kruger phillip.kruger@gmail.com

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that already but just so that it doesn't get merged too soon: we will need a Jakarta version and an update to the rewrite.yml file.
Thanks.

@phillip-kruger
Copy link
Member Author

That is why this is still a draft. Busy with the 2.0.0.RC release

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 10, 2022
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 10, 2022

Failures look related.

@quarkus-bot

This comment has been minimized.

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
@phillip-kruger
Copy link
Member Author

@gsmet Yes native failed due to new i18n resource from graphql-java. Fixed now. Should be ok, lets see what CI does now.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 11, 2022

Failing Jobs - Building 694cacc

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit 32d1c1a into quarkusio:main Aug 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 11, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 11, 2022
@phillip-kruger
Copy link
Member Author

Thanks @gsmet !

@phillip-kruger phillip-kruger deleted the graphql-upgrade branch August 11, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants