GraphQL: Make sure the context terminate #26777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
previously approved these changes
Jul 18, 2022
gsmet
reviewed
Jul 18, 2022
...untime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLAbstractHandler.java
Outdated
Show resolved
Hide resolved
cescoffier
requested changes
Jul 18, 2022
...untime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLAbstractHandler.java
Outdated
Show resolved
Hide resolved
|
@cescoffier if the method is in a try-finally, the context terminate too early. |
|
Sorry, it should be in the throw clause not finally clause |
|
You mean try - catch (Throwable) ? |
phillip-kruger
force-pushed
the
jwt-issue
branch
from
20576ca
to
a41af07
Compare
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
phillip-kruger
force-pushed
the
jwt-issue
branch
from
a41af07
to
48787de
Compare
gsmet
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Looks good to me but I will let @cescoffier have the final say on it.
cescoffier
approved these changes
Jul 18, 2022
Ladicek
reviewed
Jul 18, 2022
...untime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLAbstractHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26748
Added tests for this scenario.
Signed-off-by: Phillip Kruger phillip.kruger@gmail.com