Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use grpc instead of grpc-server for the Kubernetes port name #26732

Merged
merged 1 commit into from Jul 14, 2022
Merged

Use grpc instead of grpc-server for the Kubernetes port name #26732

merged 1 commit into from Jul 14, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 14, 2022

Originally reported here

@geoand geoand requested a review from cescoffier July 14, 2022 09:33
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Jul 14, 2022
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 14, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 14, 2022

Failing Jobs - Building a763f50

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/opentelemetry/opentelemetry/deployment integration-tests/devmode integration-tests/grpc-external-proto-test and 12 more

📦 extensions/grpc/deployment

✖ io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.websocketTest line 53 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest that uses java.util.List was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand geoand merged commit f0bcfeb into quarkusio:main Jul 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 14, 2022
@geoand geoand deleted the k8s-grpc branch July 14, 2022 10:45
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 14, 2022
@gsmet gsmet modified the milestones: 2.12 - main, 2.10.3.Final Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/grpc gRPC
Projects
None yet
Milestone
2.10.3.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geoand @cescoffier @gsmet