Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename misspelled OIDC DevUI 'webClienTimeout' to 'webClientTimeout' #26667

Merged

Conversation

sberyozkin
Copy link
Member

Fixes #26648.

This PR fixes a typo in OIDC DevUI webClienTimeout and also removed a deprecated and also misspelled webClienTimeout.
I'm not sure this PR should be marked with a release/breaking-change label as I can't imagine users actually using these mistyped properties which are also the build time only properties affecting Dev UI only, but I've added it just in case

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@sberyozkin sberyozkin force-pushed the misspelled_oidc_dev_ui_timeout_prop branch from c8b0551 to a806b85 Compare July 12, 2022 10:10
@sberyozkin sberyozkin merged commit fe8bca7 into quarkusio:main Jul 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 12, 2022
@sberyozkin sberyozkin deleted the misspelled_oidc_dev_ui_timeout_prop branch July 12, 2022 11:30
@gsmet
Copy link
Member

gsmet commented Jul 12, 2022

@sberyozkin could you just add a quick note about it at the bottom of https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.11 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename misspelled property io.quarkus.oidc.deployment.DevUiConfig#webClienTimeout to webClientTimeout
2 participants