Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & Remove legacy codegen #26659

Merged
merged 1 commit into from Jul 12, 2022
Merged

Refactor & Remove legacy codegen #26659

merged 1 commit into from Jul 12, 2022

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jul 11, 2022 •
edited

This has been in my TODO forever :)

@ia3andy ia3andy requested a review from aloubyansky July 11, 2022 12:45
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/jbang Issues related to when using jbang.dev with Quarkus area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 11, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
aloubyansky
aloubyansky approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see!

@aloubyansky
Copy link
Member

Although

Error:  io.quarkus.devtools.commands.CreateProjectHelperTest.givenKotlinProjectWithVersion18ShouldReturn17  Time elapsed: 0.002 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <17> but was: <11>

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 11, 2022

Although

Error:  io.quarkus.devtools.commands.CreateProjectHelperTest.givenKotlinProjectWithVersion18ShouldReturn17  Time elapsed: 0.002 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <17> but was: <11>

Will have a look :)

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 11, 2022

Although

Error:  io.quarkus.devtools.commands.CreateProjectHelperTest.givenKotlinProjectWithVersion18ShouldReturn17  Time elapsed: 0.002 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <17> but was: <11>

Will have a look :)

fixed

@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 12, 2022

I fixed a test which was specifying path hardcoded instead of using the builder (it failed since the key is now different)

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 12, 2022

Failing Jobs - Building 2bf0c5a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-reactive integration-tests/opentelemetry-vertx

📦 integration-tests/opentelemetry-reactive

✖ io.quarkus.it.opentelemetry.reactive.OpenTelemetryReactiveClientTest.post line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <ca7607d74f21b8fc> but was: <6d0f99bc75a7101c>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

📦 integration-tests/opentelemetry-vertx

✖ io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus line 128 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CONSUMER> but was: <PRODUCER>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 12, 2022

@aloubyansky error seems unrelated right?

@aloubyansky aloubyansky merged commit 152d0b1 into quarkusio:main Jul 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 12, 2022
@ia3andy ia3andy deleted the refactor-devtools branch July 12, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/jbang Issues related to when using jbang.dev with Quarkus area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.11.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ia3andy @aloubyansky