Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to add custom log handlers to the root logger #26657

Merged
merged 1 commit into from Jul 13, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 11, 2022

Resolves: #17480

@rmanibus
Copy link
Contributor

rmanibus commented Jul 11, 2022

@geoand I'm not sure I understand how to add a handler to the root category after that ?

quarkus.log.category."".handlers=CONSOLE_MIRROR

Or

quarkus.log.handlers=CONSOLE_MIRROR

?
I think this should be mentioned in the doc

@geoand
Copy link
Contributor Author

geoand commented Jul 11, 2022

No category is needed, it would be something like:

quarkus.log.handler.file.CONSOLE_MIRROR.enable=true
quarkus.log.handler.file.CONSOLE_MIRROR.path=quarkus.log

quarkus.log.handlers=CONSOLE_MIRROR

And yes, if we do add this, the docs will need an update

@rmanibus
Copy link
Contributor

Understood, this looks great, thanks a lot!

Do you have an opinion about:
#17480 (comment)

maybe it should be filled in a different issue ? I'm even not sure this is still an issue as it was reported for quarkus 1.3 or so

@geoand
Copy link
Contributor Author

geoand commented Jul 11, 2022

If it is still an problem, best open a new issue

@geoand
Copy link
Contributor Author

geoand commented Jul 12, 2022

@dmlloyd is this what you had in mind for #17480?

Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me, with one minor comment about the docs.

@geoand geoand marked this pull request as ready for review July 13, 2022 03:54
@geoand
Copy link
Contributor Author

geoand commented Jul 13, 2022

Thanks.

PR updated and taken out of draft

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2022
Resolves: quarkusio#17480

Co-authored-by: David M. Lloyd <david.lloyd@redhat.com>
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 13, 2022

Failing Jobs - Building f0ff8d3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with com.example.grpc.hibernate.BlockingRawTest was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand geoand merged commit 9129da3 into quarkusio:main Jul 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 13, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2022
@geoand geoand deleted the #17480 branch July 13, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus.log.console.enable disable file log handlers
3 participants