New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to add custom log handlers to the root logger #26657
Conversation
@geoand I'm not sure I understand how to add a handler to the root category after that ?
Or
? |
No category is needed, it would be something like: quarkus.log.handler.file.CONSOLE_MIRROR.enable=true
quarkus.log.handler.file.CONSOLE_MIRROR.path=quarkus.log
quarkus.log.handlers=CONSOLE_MIRROR And yes, if we do add this, the docs will need an update |
Understood, this looks great, thanks a lot! Do you have an opinion about: maybe it should be filled in a different issue ? I'm even not sure this is still an issue as it was reported for quarkus 1.3 or so |
If it is still an problem, best open a new issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good to me, with one minor comment about the docs.
core/runtime/src/main/java/io/quarkus/runtime/logging/LogConfig.java
Outdated
Show resolved
Hide resolved
Thanks. PR updated and taken out of draft |
Resolves: quarkusio#17480 Co-authored-by: David M. Lloyd <david.lloyd@redhat.com>
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building f0ff8d3
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/grpc-hibernate
📦 integration-tests/grpc-hibernate✖
|
Resolves: #17480