Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various typos in code #26650

Merged
merged 1 commit into from Jul 12, 2022
Merged

Fix various typos in code #26650

merged 1 commit into from Jul 12, 2022

Conversation

marcwrobel
Copy link
Contributor

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2022

/cc @ebullient, @jmartisk

@quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet requested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just spotted something that needs fixing in a POM (and maybe several of them to make things consistent).

...azon-lambda/event-server/src/main/java/io/quarkus/amazon/lambda/runtime/MockEventServer.java
}

protected void defaultHanderSetup() {
protected void defaultHandlerSetup() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself: we will need a note in the migration guide for this one.

extensions/panache/hibernate-reactive-rest-data-panache/deployment/pom.xml Outdated Show resolved Hide resolved
@marcwrobel marcwrobel requested a review from gsmet July 11, 2022 11:21
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 11, 2022
@ebullient ebullient added this to Review pending in Quarkus Documentation Jul 11, 2022
Quarkus Documentation automation moved this from Review pending to Reviewer approved Jul 12, 2022
@gsmet gsmet merged commit e55f11a into quarkusio:main Jul 12, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Jul 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 12, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2022
@marcwrobel marcwrobel deleted the fix-typo-extension-code branch July 12, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@mamadaliev mamadaliev mamadaliev approved these changes

Assignees
No one assigned
Labels
area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/documentation area/fault-tolerance area/funqy area/graphql area/grpc gRPC area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search / Elasticsearch area/hibernate-validator Hibernate Validator area/jaeger area/keycloak area/kubernetes area/mailer area/metrics area/mongodb area/oidc area/openapi area/panache area/persistence area/qute The template engine area/reactive-messaging area/resteasy-reactive area/smallrye area/spring Issues relating to the Spring integration area/vertx
Projects
Quarkus Documentation
Done
Milestone
2.11.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcwrobel @gsmet @mamadaliev