Improve container image repository checks for some dev services #26624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
geoand
changed the title
Ladicek
reviewed
Jul 11, 2022
.../main/java/io/quarkus/apicurio/registry/devservice/DevServicesApicurioRegistryProcessor.java
Show resolved
Hide resolved
|
Also CC @ozangunalp. |
ozangunalp
approved these changes
Jul 11, 2022
mamadaliev
approved these changes
Jul 12, 2022
Ladicek
force-pushed
the
24308_apicurio_registry_mem_image
branch
from
ce8927d
to
28e621c
Compare
|
I have pushed a commit to this PR that unifies the container image repository name checks in all 3 dev services that still perform them. |
Ladicek
changed the title
Ladicek
changed the title
This comment has been minimized.
This comment has been minimized.
…me dev services This commit improves container image name checks for these dev services: - Apicurio Registry - ActiveMQ Artemis (AMQP) - RabbitMQ These dev services used to verify that the image repository is equal to a hard-coded string. This commit changes that to verify that the image repository _ends with_ the same hard-coded string, which allows for repository namespacing in private container registries.
Ladicek
force-pushed
the
24308_apicurio_registry_mem_image
branch
from
28e621c
to
d0e1915
Compare
|
@ozangunalp Could you please take another look and then I'll merge? |
|
Thanks! |
|
Thanks a lot for solving this issue ;) |
|
Thank you for submitting the PR in the first place! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves container image name checks for these dev services:
These dev services used to verify that the image repository is equal
to a hard-coded string. This commit changes that to verify that
the image repository ends with the same hard-coded string, which
allows for repository namespacing in private container registries.
Fixes #24308