Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkiverse template build and release #26575

Merged
merged 1 commit into from Aug 23, 2022

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jul 6, 2022

Using only verify in mvn build and release won't let codestart tests pass.
Reason is that the tests are using the actual artifacts which should be installed in the local repo with install.

Note: install is the goal just after verify

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 6, 2022
@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 6, 2022

@FroMage this is the PR to merge if your Renarde release passes.

@ia3andy ia3andy requested a review from gastaldi July 6, 2022 08:44
@gastaldi
Copy link
Contributor

gastaldi commented Jul 6, 2022

That seems to be specific to the Renarde build and not necessary for other extensions, so I'm +0 for this.

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 6, 2022

@gastaldi no this is for all Quarkiverse extensions with a codestart

@gastaldi
Copy link
Contributor

gastaldi commented Jul 6, 2022

Ah I see. Are we already generating a codestart project next to the extension?

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 6, 2022

Ah I see. Are we already generating a codestart project next to the extension?

wdym?

@gastaldi
Copy link
Contributor

gastaldi commented Jul 6, 2022

Ah I see. Are we already generating a codestart project next to the extension?

wdym?

You said this change is for Quarkiverse extensions with a codestart, I wonder if quarkus create extension foobar, for example, created a codestart/ module next to the other modules

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 6, 2022

Ah I see. Are we already generating a codestart project next to the extension?

wdym?

You said this change is for Quarkiverse extensions with a codestart, I wonder if quarkus create extension foobar, for example, created a codestart/ module next to the other modules

Not yet, but we should make this available as an option for sure!

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 18, 2022

@ia3andy ia3andy marked this pull request as ready for review July 18, 2022 13:27
@@ -47,7 +47,7 @@ jobs:
- name: Maven release ${{steps.metadata.outputs.current-version}}
run: |
git checkout -b release
mvn -B release:prepare -Prelease -DreleaseVersion=${{steps.metadata.outputs.current-version}} -DdevelopmentVersion=${{steps.metadata.outputs.next-version}}
mvn -B release:prepare -Prelease -DpreparationGoals="clean install" -DreleaseVersion=${{steps.metadata.outputs.current-version}} -DdevelopmentVersion=${{steps.metadata.outputs.next-version}}
Copy link
Contributor

@gastaldi gastaldi Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the project's pom.xml instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be possible but is it worth the effort? Do we release in some other place?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's wait for the Quarkiverse parent release and I'll update this PR (parent version + build) then 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ia3andy could you rebase this PR with the latest parent? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't released quarkiverse-parent yet, I'm waiting for the next JReleaser release to do it all in one batch :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW JReleaser 1.2.0 comes out by the end of August. We've adopted a 2 month release cadence for stable releases to help with planning jreleaser/jreleaser#873

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased, but I am not sure if we should merge this or not... Maybe it's better to have this until we have the actual fix ready?

@quarkus-bot

This comment has been minimized.

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 19, 2022

@gsmet I think we should merge this for 2.12.Final, without this, new Quarkiverse extensions with codestarts won't pass CI.

Anyway it will all change, when @gastaldi add JReleaser.

@gsmet gsmet merged commit a58ae36 into quarkusio:main Aug 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 23, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.0.Final Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants