New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Redis Client API #26268
New Redis Client API #26268
Conversation
5879d66
to
36f9b12
Compare
36f9b12
to
405714e
Compare
This comment has been minimized.
This comment has been minimized.
405714e
to
977529c
Compare
Thanks @cescoffier for this. Very nice improvements. I'll have a proper look in the next couple of days. |
977529c
to
ff39ac6
Compare
863dd02
to
3cdeb6e
Compare
Is it too much to ask to bring the appropriate doc templates into your new docs? docs/src/main/asciidoc/redis.adoc -- Is that meant to be a tutorial? (I believe so.. ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor doc suggestions, otherwise lgtm.
Will it be possible to add a migration note as well as there are some breaking changes?
I love the direction that this is taking with typesafety, repository style api, thanks @cescoffier for the PR.
3cdeb6e
to
7235340
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7235340
to
552f97b
Compare
This comment has been minimized.
This comment has been minimized.
Vert.x 4.3.1 Redis clients has a few API breakage. This commit works around them. In addition, Redis 7.0 dropped the host and post commands. These commands are not exposed in the new API and are deprecated in the old one.
552f97b
to
31af6c9
Compare
Failing Jobs - Building 31af6c9
Full information is available in the Build summary check run. Failures⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
|
The current Redis extension does not provide all the possibilities Redis offers, and the API is not easy to use.
This PR provides a new high-level and type-safe Redis API that covers the previous API's shortcomings.
The previous API is still available but deprecated.
Breaking Changes
Unfortunately, while refactoring the extension, I had to break a few things:
@Identifier
instead of@Named
(following @mkouba's advice)What's missing (and will come later)
The PR is already big enough, and some parts will be provided later without breakage:
stream
group are not yet provided (you can use custom commands for the time being)LCS
command does not provide theIDX
optionRelated issues