Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC Dev UI - add bean dependency graph #26153

Merged
merged 1 commit into from Jun 16, 2022
Merged

ArC Dev UI - add bean dependency graph #26153

merged 1 commit into from Jun 16, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 15, 2022

@mkouba mkouba added this to the 2.11 - main milestone Jun 15, 2022
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/vertx labels Jun 15, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
phillip-kruger
phillip-kruger approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

@phillip-kruger
Copy link
Member

@mkouba this is very cool. I'll look into small cosmetic changes in a separate PR. This looks great !
image

@mkouba
Copy link
Contributor Author

mkouba commented Jun 16, 2022

@mkouba this is very cool. I'll look into small cosmetic changes in a separate PR. This looks great !

Thanks and +1 for further development and cosmetic improvements! I need to fix this PR first though - the CI failure is related.

@mkouba mkouba force-pushed the issue-26065 branch 2 times, most recently from afdf04e to 0b7b1af Compare June 16, 2022 09:04
@mkouba
Copy link
Contributor Author

mkouba commented Jun 16, 2022

I fixed the problem with circular dependency so the CI should be green now ;-).

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 16, 2022
manovotn
manovotn approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played with it using some quickstart samples and it looks really amazing!

@gsmet
Copy link
Member

gsmet commented Jun 16, 2022

Deserves to be in the release announcement IMHO, I added the appropriate label.

@gsmet
Copy link
Member

gsmet commented Jun 16, 2022

@phillip-kruger in your upcoming UI improvement PR, please add a screenshot so that I can use it for the announcement :).

@phillip-kruger
Copy link
Member

Will do.

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Jun 16, 2022

Hm, the rest-client-reactive-jaxb failures do not seem to be related. @gsmet does it ring a bell?

@gsmet
Copy link
Member

gsmet commented Jun 16, 2022

Yes: https://github.com/quarkusio/quarkus/pull/26173/files .

@mkouba @gsmet
ArC Dev UI - add bean dependency graph
e43a6eb 
- also add DEBUG logging for unremovable beans
- resolves quarkusio#26065
@gsmet
Copy link
Member

gsmet commented Jun 16, 2022

I rebased anyway as a few modules were skipped because of the unrelated failure and I want to make sure everything is working fine.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2022

Failing Jobs - Building e43a6eb

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit ec1d5b7 into quarkusio:main Jun 16, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/vertx kind/enhancement New feature or request release/noteworthy-feature
Projects
None yet
Milestone
2.11.0.CR1
Development

Successfully merging this pull request may close these issues.

Bean tree/graph in Quarkus Dev UI
4 participants
@mkouba @phillip-kruger @gsmet @manovotn