Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted config for removed resources in the ExtensionDescriptorMojo to have valid XML #26118

Merged

Conversation

aloubyansky
Copy link
Member

Follow up to #26025

Now it looks like

      <plugin>
        <groupId>io.quarkus</groupId>
        <artifactId>quarkus-extension-maven-plugin</artifactId>
        <version>${quarkus.platform.version}</version>
        <executions>
          <execution>
            <phase>compile</phase>
            <goals>
              <goal>extension-descriptor</goal>
            </goals>
            <configuration>
              <deployment>${project.groupId}:${project.artifactId}-deployment:${project.version}</deployment>
              <removedResources>
                <artifact>
                  <key>org.acme:acme-resources</key>
                  <resources>META-INF/a</resources>
                </artifact>
              </removedResources>
            </configuration>

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jun 14, 2022
@aloubyansky
Copy link
Member Author

fyi @xstefank

@aloubyansky
Copy link
Member Author

@gsmet I marked it for backport, since @xstefank needed it in 1.10.

@xstefank
Copy link
Contributor

I don't have a particular use case for backport. However, LRA wouldn't work by default from the release when resteasy-reactive (and thus required reactive REST client) was made default.

@aloubyansky
Copy link
Member Author

@xstefank I thought you wanted this feature before June 20. If we are not backporting this PR it's going to end up in 1.11 for which we don't have a schedule yet.

@gsmet
Copy link
Member

gsmet commented Jun 14, 2022

You're talking about 2.10 and 2.11, right? I think we can backport it as it doesn't work very well right now.

@aloubyansky
Copy link
Member Author

Are our Gradle tests unstable lately?

@quarkus-bot

This comment has been minimized.

@aloubyansky aloubyansky force-pushed the ext-removed-resources-adjustment branch from 2020e83 to 26f9c40 Compare June 14, 2022 20:03
@aloubyansky
Copy link
Member Author

I rebased just to see the effect on the CI.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2022

Failing Jobs - Building 26f9c40

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/elasticsearch-rest-client 

📦 integration-tests/elasticsearch-rest-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.0:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-client: I/O Error

@gastaldi gastaldi merged commit 78d555d into quarkusio:main Jun 15, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 15, 2022
@xstefank
Copy link
Contributor

@aloubyansky @gsmet I have an LRA talk next week at DevoxxPL so if we can backport and have a release where I don't need to explain resteasy vs resteasy reactive in the talk that would be great. But if it's too much effort then nothing serious.

@aloubyansky
Copy link
Member Author

Here we go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants