Fix hibernate-reactive-rest-data-panache when adding smallrye openapi #26074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request will generate the rest data methods using the method signature that allows to use parameterized types. Fix quarkusio#25990
geoand
approved these changes
Jun 13, 2022
geoand
approved these changes
Jun 13, 2022
| import io.quarkus.gizmo.DescriptorUtils; | ||
| import io.quarkus.gizmo.MethodCreator; | ||
|
|
||
| public final class SignatureMethodCreator { |
There was a problem hiding this comment.
Just checking: we don't already have something like this in Panache, do we?
There was a problem hiding this comment.
I could not find something similar in Panache.
We could move it to the gizmo extension or even be part of the ClassCreator API. From my point of view, this is a good candidate for doing it in a second iteration.
Sgitario
added a commit
to Sgitario/gizmo
that referenced
this pull request
Jun 15, 2022
This pull request handles the support of parameterized types when creating methods. Example:
```java
public List<String> methodName() {
}
```
Where `List<String>` is a parameterized type.
In order to do this, we need to amend the `signature` of the method as the descriptor does not support it (it says class not found when trying to declare `Ljava.util.List<Ljava.lang.String;>;`).
In order to resolve this, we have added a wrapper type `ParameterizedClass` where we can specify the wrapper type and the param types. Usage:
```
MethodCreator method = creator.getMethodCreator("methodName", new ParameterizedClass(List.class, String.class));
```
This pull request partially resolves: quarkusio#66 (which is intended to be for classes too)
Moreover, these changes are inspired by the changes in quarkusio/quarkus#26074 (that there will be deprecated once gizmo dependency is bumped).
I've verified these changes in Quarkus upstream too (reverting the changes of the mentioned Quarkus pull request) and it worked fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will generate the rest data methods using the method signature that allows to use parameterized types.
Fix #25990