Fix container build logging

[knutwannheden]

In Quarkus 2.10.CR1, the container build (e.g. Docker) performed by Quarkus does not log any output anymore. This appears to be caused by the refactoring in commit 418d986, as the Runnable#run() method is never called in ExecUtil#exec() on the Runnable returned by outputFilterFunction.

[knutwannheden]

I didn't really look at what exactly the referenced commit does. I just noticed that the call of the run() method appears to be missing. On the 2.9 branch the situation is the same. There the corresponding commit is 3556287. On 2.8 and older branches the problem doesn't exist.

[knutwannheden]

/cc @geoand

[geoand]

Thanks!

[knutwannheden]

In our case this fix is in fact very important. When the stdout and stderr isn't consumed, the process will at some point just hang. Presumably because the allocated buffer has been filled. This is only problematic when there is a lot of output.

[quarkus-bot]

Failing Jobs - Building 0ca82fd

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

[gsmet]

Thanks for testing and for the quick fix!

[knutwannheden]

@gsmet Since this bug is also present in 2.9, should the triage/backport-2.9? label also be added?

[geoand]

There will be no more 2.9 releases (unless something goes very wrong) now that we have a first 2.10 release out

[knutwannheden]

There will be no more 2.9 releases (unless something goes very wrong) now that we have a first 2.10 release out

Thanks for the clarification. Since the label was mentioned only 4 days ago I thought it may still be relevant :-)