Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package of hibernate-orm/deployment-spi #26027

Merged
merged 1 commit into from Jun 9, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 9, 2022

The package is incorrect and makes the javadoc build fail.

The package is incorrect and makes the javadoc build fail.
@gsmet gsmet added this to the 2.10.0.CR1 milestone Jun 9, 2022
@gsmet
Copy link
Member Author

gsmet commented Jun 9, 2022

I already backported it as it's blocking the release.

@gsmet gsmet requested a review from yrodiere June 9, 2022 13:10
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 9, 2022
@Sanne
Copy link
Member

Sanne commented Jun 9, 2022

We only spot such an issue when you attempt a release?

@yrodiere
Copy link
Member

yrodiere commented Jun 9, 2022

We only spot such an issue when you attempt a release?

I was also surprised; since I know for sure this class is used during integration tests (among others), this basically means the directory structure of packages is not as important as I thought it was. Except for javadoc, evidently.

@gsmet
Copy link
Member Author

gsmet commented Jun 9, 2022

So we actually have a build testing the release posting on status.quarkus.io but I was too busy/on PTO/at JNation to actually have a look before today.

And yes only javadoc chokes on this, the rest seems to ignore the problem. It's not the first time.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2022

Failing Jobs - Building 590edfe

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

@gastaldi
Copy link
Contributor

gastaldi commented Jun 9, 2022

Holy crap, I didn't notice that either when renaming this class

@gastaldi gastaldi merged commit 6fd604d into quarkusio:main Jun 9, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2022

Milestone is already set for some of the items:

  • The pull request itself

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 9, 2022
@gsmet
Copy link
Member Author

gsmet commented Jun 9, 2022

@geoand it seem that all the Windows build are now timing out in AppCDS. I don't know if it's related to this module or something else but I had at least 2 builds failing there for totally different changes. See for instance https://github.com/quarkusio/quarkus/commit/590edfefbe5ec04aa255dac9dc9d47ccb9d01643/checks/6812364928/logs .

And this one was a small build of only 40 minutes for the Linux builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants