New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package of hibernate-orm/deployment-spi #26027
Conversation
The package is incorrect and makes the javadoc build fail.
I already backported it as it's blocking the release. |
We only spot such an issue when you attempt a release? |
I was also surprised; since I know for sure this class is used during integration tests (among others), this basically means the directory structure of packages is not as important as I thought it was. Except for javadoc, evidently. |
So we actually have a build testing the release posting on status.quarkus.io but I was too busy/on PTO/at JNation to actually have a look before today. And yes only javadoc chokes on this, the rest seems to ignore the problem. It's not the first time. |
Holy crap, I didn't notice that either when renaming this class |
Milestone is already set for some of the items:
We haven't automatically updated the milestones for these items.
|
@geoand it seem that all the Windows build are now timing out in AppCDS. I don't know if it's related to this module or something else but I had at least 2 builds failing there for totally different changes. See for instance https://github.com/quarkusio/quarkus/commit/590edfefbe5ec04aa255dac9dc9d47ccb9d01643/checks/6812364928/logs . And this one was a small build of only 40 minutes for the Linux builds. |
The package is incorrect and makes the javadoc build fail.