Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DatasourceDbKindHibernateOrmMetadataBuildItem to DatabaseKindDialectBuildItem #25918

Merged
merged 2 commits into from Jun 6, 2022
Merged

Rename DatasourceDbKindHibernateOrmMetadataBuildItem to DatabaseKindDialectBuildItem #25918

merged 2 commits into from Jun 6, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jun 2, 2022

As suggested in #25792 (comment)

@gastaldi gastaldi mentioned this pull request Jun 2, 2022
Merged
@gastaldi gastaldi requested review from yrodiere and gsmet June 2, 2022 02:52
@yrodiere
Copy link
Member

yrodiere commented Jun 6, 2022

I would have used DatabaseKindMetadataBuildItem, because it's more future proof, but... Ok, enough bikeshedding 😀 Let's merge it.

@alexeysharadin be aware the name of the build item is changing.

@yrodiere yrodiere merged commit 319d03e into quarkusio:main Jun 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone Jun 6, 2022
@gastaldi gastaldi deleted the rename_build_item branch June 6, 2022 13:33
@yrodiere
Copy link
Member

yrodiere commented Jun 7, 2022

Oh, also... Thank you @gastaldi :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-reactive area/persistence
Projects
None yet
Milestone
2.10.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gastaldi @yrodiere