Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guide] fix reactive-sql-clients startup method #25816

Merged
merged 1 commit into from Jun 13, 2022
Merged

[Guide] fix reactive-sql-clients startup method #25816

merged 1 commit into from Jun 13, 2022

Conversation

SIMULATAN
Copy link
Contributor

The way stated in the docs doesn't work (at least on my machine) because the await method blocks the thread which is not allowed apparently.

Screenshots:
website
ide

@quarkus-bot
Copy link

quarkus-bot bot commented May 26, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Sanne Sanne requested a review from tsegismont June 10, 2022 12:46
tsegismont
tsegismont reviewed Jun 10, 2022
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @SIMULATAN !

@gsmet gsmet merged commit 8ce7350 into quarkusio:main Jun 13, 2022
@gsmet
Copy link
Member

gsmet commented Jun 13, 2022

Thanks!

@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 13, 2022
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.0.Final Jun 13, 2022
@gsmet gsmet modified the milestones: 2.10.0.Final, 2.7.7.Final Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@tsegismont tsegismont tsegismont approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.7.7.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SIMULATAN @gsmet @tsegismont