Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to add additional hibernate dialect for third party databases. #25792

Merged
merged 6 commits into from May 30, 2022
Merged

Add ability to add additional hibernate dialect for third party databases. #25792

merged 6 commits into from May 30, 2022

Commits on May 30, 2022

  1. add ability to add hibernate dialect for third party databases. Befor… 

    …e this - all dialects was hardcoded in Dialects.java
    @yrodiere
    alexeysharandin authored and yrodiere committed May 30, 2022
    Configuration menu
    Copy the full SHA
    cbb865d View commit details
    Browse the repository at this point in the history

  2. Create a dedicated module for Hibernate ORM SPIs

    @yrodiere
    yrodiere committed May 30, 2022
    Configuration menu
    Copy the full SHA
    61afd02 View commit details
    Browse the repository at this point in the history

  3. Move DatabaseKindBuildItem to the Hibernate ORM SPI module 

    Because dialects are metadata specific to Hibernate ORM.
    @yrodiere
    yrodiere committed May 30, 2022
    Configuration menu
    Copy the full SHA
    a4f6abf View commit details
    Browse the repository at this point in the history

  4. Handle aliases when guessing dialects based on DatasourceDbKindHibern… 

    …ateOrmMetadataBuildItem
    @yrodiere
    yrodiere committed May 30, 2022
    Configuration menu
    Copy the full SHA
    4ad8dd6 View commit details
    Browse the repository at this point in the history

  5. Remove tests of hardcoded dialects 

    These tests are not absolutely necessary since we have integration
tests for each database kind, which would fail if we targeted a
non-existing dialect.

And we won't be able to (easily) execute those tests after the next
commit anyway.
    @yrodiere
    yrodiere committed May 30, 2022
    Configuration menu
    Copy the full SHA
    11b3ba4 View commit details
    Browse the repository at this point in the history

  6. Rely on DatasourceDbKindHibernateOrmMetadataBuildItem for core databa… 

    …se kinds
    @yrodiere
    yrodiere committed May 30, 2022
    Configuration menu
    Copy the full SHA
    07b07df View commit details
    Browse the repository at this point in the history