GraphQL Non blocking support

[phillip-kruger]

This PR pulls in a new release from SmallRye (https://github.com/smallrye/smallrye-graphql/releases/tag/1.5.0) and adds supports for Non blocking operations. The same rule applies as with RESTEasy Reactive.

• By default, normal response objects will execute blocking, except if marked with @NonBlocking
• By default, Uni and CompletionStage response objects will execute non-blocking, except if marked with @Blocking

Breaking change: The ExecutionService has changed to not respond with a result, but rather a writer needs to be passed in. a default JsonObjectResponseWriter exist to get the same result as before.

Because this is a major new feature, non-blocking can be turned off using a config: quarkus.smallrye-graphql.nonblocking.enabled=false. By default it will be enabled

Signed-off-by: Phillip Kruger phillip.kruger@gmail.com

[phillip-kruger]

@geoand - There are small changes on how the locale resolver work ( in hibernate-validator) for GraphQL (something that came in a few weeks ago) - I moved the resolver to the graphql extension and are now getting the locale from the graphql context. This helps to make sure the locale are propagated.

[geoand]

Understood, thanks.

[jmartisk]

This currently makes the hibernate-validator a required dependency of the smallrye-graphql extension. To make it properly optional, we will probably need to:

• Change the dependencies in smallrye-graphql extension's poms to be <optional>true</optional>. I think we should also switch from depending on hibernate-validator directly to depending on io.quarkus:quarkus-hibernate-validator. Note that the deployment pom already has a dependency on it, it's in the test scope! We need it to be optional, but present for testing. It seems that an optional dependency is always present during tests.
• In SmallRyeGraphQLProcessor#additionalBean we need to detect whether the hibernate-validator extension is present before we produce SmallRyeGraphQLLocaleResolver as a bean. If we produce it when the extension is not there, it will blow up. This means we will probably need to add a Capability for the hibernate-validator extension, to be able to do this check.

[phillip-kruger]

Thanks @jmartisk - Agree. I can make those changes now in this PR.

[phillip-kruger]

@jmartisk - I made all the changes as you requested. I think it's all fine now. MP TCK is passing on my localhost. Please review :)

[mschorsch]

Any chance that this will be part of 2.9?

[phillip-kruger]

Any chance that this will be part of 2.9?

Not sure at this stage. Waiting for a green CI and PR approval. Might only be the next version, or allowing it here with a config option to enable it but default back to prev version

[phillip-kruger]

I have now added quarkus.smallrye-graphql.nonblocking.enabled=true that by default will be false. This allows a more soft release, so by default there is no change, but when enabled this experimental feature kicks in.

[cescoffier]

The CI failures look related.

[phillip-kruger]

@mschorsch - we missed the 2.9 release. Look out for the CR of 2.10

[mschorsch]

OK. Thanks.

[phillip-kruger]

@jmartisk @cescoffier - CI is green. Please review when you have a chance :) Thanks

[gsmet]

@jmartisk @cescoffier FWIW, this is in the way of my Jakarta work so if we can get it in soon, that would be awesome.

[phillip-kruger]

I have now added quarkus.smallrye-graphql.nonblocking.enabled=true that by default will be false. This allows a more soft release, so by default there is no change, but when enabled this experimental feature kicks in.

This is now the other way around : non-blocking can be turned off using a config: quarkus.smallrye-graphql.nonblocking.enabled=false. By default it will be enabled

[jmartisk]

LGTM, very nice work!