Mark OpenTelemetry and @ConsumeEvent context as safe #24048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @radcortez |
gsmet
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
@cescoffier confirmed me we want this in 2.7.3.Final so fast tracking this.
The rationale of the changes look good. I was the one originally complaining about QuarkusContextStorage.
gsmet
added
the
triage/waiting-for-ci
|
Milestone is already set for some of the items:
We haven't automatically updated the milestones for these items.
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
JDK 17 Java build was OK so this looks safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.