Update MS SQL JDBC driver to 11.2.0.jre11 #24010

sschu · 2022-02-28T14:04:36Z

sschu · 2022-02-28T14:07:12Z

I ran the MS SQL integration test locally without any problem.

bom/application/pom.xml

gastaldi · 2022-02-28T14:34:44Z

@sschu The PR comment must be changed to Fixes #24009

Also, make sure the commit message is more readable, something like:

Update MS SQL JDBC driver to 10.2.0.jre11

Fixes #24009

Sanne · 2022-02-28T14:38:31Z

I'll be surprised if this works in native w/o further changes, but I'll be happy to be proven wrong.. let's see what CI says about it.

gastaldi · 2022-02-28T14:39:54Z

I wonder if #23933 may help

sschu · 2022-02-28T14:48:09Z

Fixed comments, thanks.

famod · 2022-02-28T15:03:30Z

Hi @Sanne! Any reason why this is not covered by dependabot? The other drivers are...

gsmet · 2022-02-28T15:20:21Z

IIRC, the reason we haven't upgraded yet is that making the new driver work in native is not trivial and require some involved work. But we will see what CI has to say.

Hi @Sanne! Any reason why this is not covered by dependabot? The other drivers are...

Yes, because Dependabot upgrades to the jre17 flavor. And I haven't found a way to properly filter things.

famod · 2022-02-28T15:28:37Z

Ugh...I see. People really need to stop using "classifiers" in versions.

gastaldi · 2022-02-28T18:23:53Z

Apparently this change does not work when building to Native. Some juggling with the GraalVM substitutions may be required

sschu · 2022-02-28T18:30:15Z

Unfortunately. :( I only tested the MS SQL integration test and that went fine. I probably lack the skills to fix things with the native build. However, I will give #23933 a try...

gastaldi · 2022-02-28T18:32:14Z

@sschu I may be wrong, but after having a quick look at the sources, it seems that #23933 is no longer necessary with this update

sschu · 2022-03-01T13:53:28Z

Why would it not be necessary anymore? In any case, it did not help. Running the native integration tests I get:
Error: Could not find target method: private void io.quarkus.jdbc.mssql.runtime.graal.com.microsoft.sqlserver.jdbc.QuarkusSQLServerConnection.validateAdalLibrary(java.lang.String) com.oracle.svm.core.util.UserError$UserException: Could not find target method: private void io.quarkus.jdbc.mssql.runtime.graal.com.microsoft.sqlserver.jdbc.QuarkusSQLServerConnection.validateAdalLibrary(java.lang.String) at com.oracle.svm.core.util.UserError.abort(UserError.java:73) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.findOriginalMethod(AnnotationSubstitutionProcessor.java:751) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleMethodInAliasClass(AnnotationSubstitutionProcessor.java:368) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleAliasClass(AnnotationSubstitutionProcessor.java:340) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleClass(AnnotationSubstitutionProcessor.java:310) at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.init(AnnotationSubstitutionProcessor.java:266) at com.oracle.svm.hosted.NativeImageGenerator.createAnnotationSubstitutionProcessor(NativeImageGenerator.java:889) at com.oracle.svm.hosted.NativeImageGenerator.setupNativeImage(NativeImageGenerator.java:816) at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:534) at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:494) at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:426) at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:587) at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:126) at com.oracle.svm.hosted.NativeImageGeneratorRunner$JDK9Plus.main(NativeImageGeneratorRunner.java:617)
Which doesn't tell me anything. I would be willing to invest some time here, but any pointers to what might be the problem are appreciated.

gastaldi · 2022-03-01T14:06:46Z

Because the class/method the substitution is referring to no longer exists in this update

sschu · 2022-03-03T17:29:32Z

@gastaldi I played with this a little bit and by adapting substitutions to the new classes, I could make some progress. I also had to add more dependencies like azure-core. Another option I was presented is to provide a flag for classes to load dynamically. I am just missing a guidance on when should I actually add substitution to not trigger more code loading, dynamic loading or actually adding more dependencies...

gastaldi · 2022-03-04T18:47:16Z

Yeah, it's not a trivial task. In my experience, I usually achieve that by trial and error attempts.

gsmet · 2022-03-14T13:00:04Z

@sschu maybe rebase what you have and share it? Even if not finished, somebody might have a look and provide useful insights.

Thanks!

sschu · 2022-03-16T14:25:33Z

I am a bit busy atm, will do on Friday...

sschu · 2022-03-20T15:47:45Z

So I played around with this a little bit. I had an intermediate state where things only worked if I add azure-core as dependency. But then things got messy with netty dependencies being added and a conflict where it was declared as initialize-at-runtime in one place and initialize-at-buildtime at another. Surprisingly, it now seems to work also without azure-core- at least the native image build. However, the integration test itself does not succeed anymore - but it also doesn't work for me in main. Its getting a connection reset during the integration test. Not sure where this comes from. @gsmet @gastaldi Maybe you can give it a try if the integration test works for you?

bom/application/pom.xml

gastaldi · 2022-05-04T16:37:19Z

Long-term it would be nicer to actually support the disabled features
👍🏻

However, I think the correct place to put these things is the native-image.properties in the mssql-jdbc repository, not quarkus additional build args in the integration test for ms sql driver in quarkus, right?

I am not 100% sure if Quarkus uses the native-image.properties, I think this feature was disabled some time ago

Sanne · 2022-05-04T16:51:12Z

We don't generally disable native-image.properties althought we had to do so in particular circumstances, as people have been adding directives into the libraries and sometimes make mistakes, or are compatible only with a very particular version of GraalVM. So adding directives into the libraries has some drawbacks.

In particular if you enable all features of a library and hard code this, then it becomes much bigger, less optimised code, and also amplifies the compilation times. So that's why in Quarkus we prefer to have "knobs" (the build items) so that we can enable/disable the particular features a developer is needing.

But it makes sense for some essential features to be enabled directly in the native-image.properties; for example if there's some reflection need that is always going to be needed for every user of the library, then it's useful to include it in the library.

We're actually having conversations with the GraalVM engineering team about this very topic, wondering how we can help libraries but also without the performance hit; hopefully we'll be able to figure out some way to provide a vendor neutral / standardized approach similar to what Quarkus does, so that metadata can be included within the libraries without making them less "light" when features are not used.

sschu · 2022-05-04T17:10:50Z

@Sanne Got it. However, that means everybody trying to build a native image would have to come up with the same list of classes to be initialized at runtime I used for the mssql integration test? Worse even, his list could look a bit different if it uses different code-paths? And therefore using native-image properties could at least provide some baseline?

sschu · 2022-08-12T10:39:29Z

@Sanne @gastaldi Since the MS SQL driver is finally released, I updated this PR accordingly for version 11.2.0. Can you please give the CI a go? I currently have docker problems running the CI locally.

extensions/jdbc/jdbc-mssql/runtime/pom.xml

Sanne

Seems to work - excellent, thanks!

Fixes quarkusio#24009 Co-authored-by: George Gastaldi <gegastaldi@gmail.com>

Sanne · 2022-08-15T09:27:05Z

rebased the PR and removed the no longer applicable comment about adal4j from the pom.xml

sschu · 2022-08-15T09:35:19Z

Thanks a lot!

quarkus-bot · 2022-08-15T14:21:38Z

Failing Jobs - Building `301654e`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 18	`Build`	Failures	Logs	Raw logs
✖	Native Tests - HTTP	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/rest-client integration-tests/smallrye-context-propagation

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/smallrye-context-propagation

✖ io.quarkus.context.test.SimpleContextPropagationTest.testArcMEContextPropagationDisabled line 83 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/rest-client

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment integration-tests/rest-client 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 line 83 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 4 State{lastRun=3, running=true, inProgress=true, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2(KafkaDevServicesContinuousTestingTestCase.java:83)

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 18 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment integration-tests/rest-client 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 line 87 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 5 State{lastRun=4, running=true, inProgress=true, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2(KafkaDevServicesContinuousTestingTestCase.java:87)

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Native Tests - HTTP #

- Failing: integration-tests/rest-client

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedITCase.should_accept_self_signed_certs - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedITCase.should_accept_self_signed_certs_java_url - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllIT.restClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostIT.restClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

Sanne · 2022-08-15T14:23:17Z

Looks like CI is in trouble, but these failing tests are unrelated. I'll merge.
Thanks all!

Sanne · 2022-08-15T21:19:59Z

Related: hibernate/hibernate-orm#5209

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence labels Feb 28, 2022

gastaldi reviewed Feb 28, 2022

View reviewed changes

bom/application/pom.xml Outdated Show resolved Hide resolved

Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2022

sschu force-pushed the 24009-update-ms-sql-jdbc-driver-to-10.2.0 branch from e710d75 to e6d1b97 Compare February 28, 2022 14:46

sschu changed the title ~~24009 update MS SQL JDBC driver to 10.2.0~~ Fixes #24009 Feb 28, 2022

gastaldi changed the title ~~Fixes #24009~~ Update MS SQL JDBC driver to 10.2.0.jre11 Feb 28, 2022

gastaldi removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 28, 2022

This comment has been minimized.

Sign in to view

sschu force-pushed the 24009-update-ms-sql-jdbc-driver-to-10.2.0 branch from e6d1b97 to 5aaa643 Compare March 20, 2022 15:39

gastaldi reviewed Mar 20, 2022

View reviewed changes

bom/application/pom.xml Show resolved Hide resolved

sschu force-pushed the 24009-update-ms-sql-jdbc-driver-to-10.2.0 branch from c0fe94b to 912bfb4 Compare May 4, 2022 15:52

sschu mentioned this pull request Jun 9, 2022

[QUESTION] Dependencies and Configuration needed for database connectivity using Manage Identity in AKS microsoft/mssql-jdbc#1844

Closed

sschu force-pushed the 24009-update-ms-sql-jdbc-driver-to-10.2.0 branch from 912bfb4 to 60ab59b Compare August 12, 2022 10:36

sschu changed the title ~~Update MS SQL JDBC driver to 10.2.0.jre11~~ Update MS SQL JDBC driver to 12.2.0.jre11 Aug 12, 2022

sschu marked this pull request as ready for review August 12, 2022 10:37

sschu force-pushed the 24009-update-ms-sql-jdbc-driver-to-10.2.0 branch from 60ab59b to 8f92b01 Compare August 12, 2022 11:07

sschu changed the title ~~Update MS SQL JDBC driver to 12.2.0.jre11~~ Update MS SQL JDBC driver to 11.2.0.jre11 Aug 12, 2022

This comment has been minimized.

Sign in to view

Sanne reviewed Aug 15, 2022

View reviewed changes

extensions/jdbc/jdbc-mssql/runtime/pom.xml Outdated Show resolved Hide resolved

Sanne approved these changes Aug 15, 2022

View reviewed changes

Update MS SQL JDBC driver to 11.1.1.jre11

301654e

Fixes quarkusio#24009 Co-authored-by: George Gastaldi <gegastaldi@gmail.com>

Sanne force-pushed the 24009-update-ms-sql-jdbc-driver-to-10.2.0 branch from 8f92b01 to 301654e Compare August 15, 2022 09:26

Sanne added triage/waiting-for-ci Ready to merge when CI successfully finishes kind/enhancement New feature or request release/noteworthy-feature and removed area/hibernate-orm Hibernate ORM labels Aug 15, 2022

Sanne merged commit bccd9a1 into quarkusio:main Aug 15, 2022

quarkus-bot bot added this to the 2.12 - main milestone Aug 15, 2022

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 15, 2022

This was referenced Aug 17, 2022

Avoid SQL Server JDBC driver to load ANTLR parsers #27343

Merged

Exclude com.microsoft.azure:msal4j from the application BOM #27359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update MS SQL JDBC driver to 11.2.0.jre11 #24010

Update MS SQL JDBC driver to 11.2.0.jre11 #24010

sschu commented Feb 28, 2022 •

edited by gastaldi

sschu commented Feb 28, 2022

gastaldi commented Feb 28, 2022 •

edited

Sanne commented Feb 28, 2022

gastaldi commented Feb 28, 2022

sschu commented Feb 28, 2022

famod commented Feb 28, 2022

gsmet commented Feb 28, 2022

famod commented Feb 28, 2022

gastaldi commented Feb 28, 2022

sschu commented Feb 28, 2022

gastaldi commented Feb 28, 2022

This comment has been minimized.

sschu commented Mar 1, 2022

gastaldi commented Mar 1, 2022 •

edited

sschu commented Mar 3, 2022 •

edited

gastaldi commented Mar 4, 2022

gsmet commented Mar 14, 2022

sschu commented Mar 16, 2022

sschu commented Mar 20, 2022

gastaldi commented May 4, 2022

Sanne commented May 4, 2022

sschu commented May 4, 2022

sschu commented Aug 12, 2022

This comment has been minimized.

Sanne left a comment

Sanne commented Aug 15, 2022

sschu commented Aug 15, 2022

quarkus-bot bot commented Aug 15, 2022

Sanne commented Aug 15, 2022

Sanne commented Aug 15, 2022

Update MS SQL JDBC driver to 11.2.0.jre11 #24010

Update MS SQL JDBC driver to 11.2.0.jre11 #24010

Conversation

sschu commented Feb 28, 2022 • edited by gastaldi

sschu commented Feb 28, 2022

gastaldi commented Feb 28, 2022 • edited

Sanne commented Feb 28, 2022

gastaldi commented Feb 28, 2022

sschu commented Feb 28, 2022

famod commented Feb 28, 2022

gsmet commented Feb 28, 2022

famod commented Feb 28, 2022

gastaldi commented Feb 28, 2022

sschu commented Feb 28, 2022

gastaldi commented Feb 28, 2022

This comment has been minimized.

sschu commented Mar 1, 2022

gastaldi commented Mar 1, 2022 • edited

sschu commented Mar 3, 2022 • edited

gastaldi commented Mar 4, 2022

gsmet commented Mar 14, 2022

sschu commented Mar 16, 2022

sschu commented Mar 20, 2022

gastaldi commented May 4, 2022

Sanne commented May 4, 2022

sschu commented May 4, 2022

sschu commented Aug 12, 2022

This comment has been minimized.

Sanne left a comment

Choose a reason for hiding this comment

Sanne commented Aug 15, 2022

sschu commented Aug 15, 2022

quarkus-bot bot commented Aug 15, 2022

Failing Jobs - Building 301654e

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/rest-client

📦 integration-tests/smallrye-context-propagation

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/rest-client

⚙️ JVM Tests - JDK 17 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

📦 integration-tests/rest-client

⚙️ JVM Tests - JDK 18 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

📦 integration-tests/rest-client

⚙️ Native Tests - HTTP #

📦 integration-tests/rest-client

Sanne commented Aug 15, 2022

Sanne commented Aug 15, 2022

sschu commented Feb 28, 2022 •

edited by gastaldi

gastaldi commented Feb 28, 2022 •

edited

gastaldi commented Mar 1, 2022 •

edited

sschu commented Mar 3, 2022 •

edited

Failing Jobs - Building `301654e`