Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Panache reactive: database name is not taken from the annotation #23973

Merged

Conversation

loicmathieu
Copy link
Contributor

Fixes #23813

@loicmathieu loicmathieu added this to the 2.8 - main milestone Feb 25, 2022
@evanchooly
Copy link
Member

though we should have tests for this in both variants...

@loicmathieu
Copy link
Contributor Author

though we should have tests for this in both variants...

I was afraid you'll said that, I knew you'll said that ...
But the test would take more time to write than the fix ! But OK, I should have done it anyway ;)

I'll write a small test next week.

@gsmet gsmet merged commit cadd896 into quarkusio:main Mar 1, 2022
@gsmet
Copy link
Member

gsmet commented Mar 1, 2022

@loicmathieu I merged this one as I want to backport it in tomorrow's version. Please add the test in a separate PR. Thanks!

@loicmathieu
Copy link
Contributor Author

@gsmet great, I'll provide a test later this week

@romilpunetha
Copy link

When is this fix getting released?

@gsmet
Copy link
Member

gsmet commented Mar 1, 2022

@romilpunetha tomorrow in 2.7.3.Final if all goes well.

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Mar 1, 2022
loicmathieu added a commit to loicmathieu/quarkus that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@MongoEntity with database parameter does not detect database when using mongo panache
4 participants