Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hibernate reactive - configure HBM2DDL script generation #23921

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Hibernate reactive - configure HBM2DDL script generation #23921

merged 1 commit into from
Mar 1, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 23, 2022

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 23, 2022 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9642262

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.ModuleWithParentDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@mkouba mkouba requested a review from DavideD February 24, 2022 07:27
DavideD
DavideD reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it seems consistent with HIbernate ORM. Shouldn't you add some tests, though?

@mkouba
Copy link
Contributor Author

mkouba commented Feb 24, 2022

LGTM and it seems consistent with HIbernate ORM. Shouldn't you add some tests, though?

Sure. I can copy the test from the ORM module ;-).

@mkouba mkouba force-pushed the hibernate-reactive-ddl-scripts branch from 9642262 to 4667114 Compare February 24, 2022 16:29
@mkouba mkouba requested a review from DavideD February 24, 2022 16:32
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 24, 2022 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4667114

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/gradle/gradle-model 
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin integration-tests/gradle

📦 devtools/gradle/gradle-model

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-model: Command execution failed.

DavideD
DavideD approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet force-pushed the hibernate-reactive-ddl-scripts branch from 4667114 to 1e121d3 Compare March 1, 2022 17:07
@gsmet
Copy link
Member

gsmet commented Mar 1, 2022

CI failure looks weird, I rebased the PR.

gsmet
gsmet approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Davide approved it!

@gsmet gsmet merged commit 86197a2 into quarkusio:main Mar 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 1, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideD DavideD DavideD approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/hibernate-reactive area/persistence
Projects
None yet
Milestone
2.7.3.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkouba @gsmet @DavideD @Sanne