Allow null values for query, cookies, headers and form params for Reactive REST Client #23876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/main/java/io/quarkus/jaxrs/client/reactive/deployment/JaxrsClientReactiveProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/quarkus/jaxrs/client/reactive/deployment/JaxrsClientReactiveProcessor.java
Outdated
Show resolved
Hide resolved
|
Looks like something we should backport? |
...st/java/io/quarkus/rest/client/reactive/registerclientheaders/RegisterClientHeadersTest.java
Show resolved
Hide resolved
geoand
force-pushed
the
#23872
branch
2 times, most recently
from
e1e1caf
to
0aaaa3d
Compare
michalszynkiewicz
approved these changes
Feb 22, 2022
geoand
added
the
triage/waiting-for-ci
|
thanks for tackling it so quickly @geoand :) |
|
No problem :) |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0aaaa3d
|
…ctive REST Client Fixes: quarkusio#23872
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
kdubb
reviewed
May 30, 2022
| @@ -2303,9 +2303,13 @@ private ResultHandle addQueryParam(BytecodeCreator methodCreator, | |||
| ResultHandle paramAnnotations) { | |||
| ResultHandle paramArray; | |||
| String componentType = null; | |||
|
|
|||
| AssignableResultHandle result = methodCreator.createVariable(WebTarget.class); | |||
| BranchResult isValueNull = methodCreator.ifNull(target); | |||
There was a problem hiding this comment.
@geoand Shouldn't this be checking queryParamHandle?
There was a problem hiding this comment.
@geoand We're still experiencing errors with null query params.
There was a problem hiding this comment.
I'll have a look tomorrow, my memory has been completely purged of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23872